18531 failed mdm profs

[jahzielv]

Related issue: #18531

Checklist for submitter

If some of the following don't apply, delete the relevant line.

• Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  See Changes files for more information.
• Added/updated tests
• Manual QA for all new/changed functionality

[jahzielv]

Dev log 2024-05-10

When Roberto and I first talked about a solution to this, we felt that filtering the profiles out here, since we already have a hostProfilesToCleanup list. The profiles in this list are deleted from the DB directly; this is exactly what we want for the case we're solving for. However, during integration testing, I found that simply adding a check there for profiles that had operation Install and had failed wasn't enough. The profiles were being marked with operationRemove and status pending somewhere else. After digging, I found the place where profiles are reassigned during host team transfers. This reassignment was erasing the information we needed (that the profile failed to install). So I added a check here, which would avoid changing the profile and would allow us to filter it out up in the ReconcileAppleProfiles method.

[roperzh]

very nice catch about the tweak in server/datastore/mysql/apple_mdm.go! left a few minor notes/questions

[mna]

LGTM once Roberto's comments are addressed!

[mna]

Nit for a future iteration maybe (not a blocker to merge!), just a visual check but it looks like this is the same as the previous processing of the command, would be nice to do this in a loop over a struct that has just the variable parts (I think it's only the assertion of profiles after the acknowledge, VerifyHostMDMProfiles).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.75%. Comparing base (676a632) to head (c32a03d).
Report is 101 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main   #18930       +/-   ##
===========================================
+ Coverage   52.03%   66.75%   +14.71%     
===========================================
  Files         352      887      +535     
  Lines        8212   108480   +100268     
  Branches     2657        0     -2657     
===========================================
+ Hits         4273    72413    +68140     
- Misses       3917    30181    +26264     
- Partials       22     5886     +5864     

Flag	Coverage Δ
backend	66.75% <100.00%> (?)
frontend	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[georgekarrv]

@jahzielv I know we said deep freeze but there are still 2 large outstanding items (software delivery and eops load testing) So lets go ahead and merge this one in since it impacts dogfood and would be good to get closed.