Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support environment variables in config profiles #18891

Merged
merged 8 commits into from
May 28, 2024

Conversation

lucasmrod
Copy link
Member

#17309

I added some missing env var replacement tests for policies, queries, etc.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated tests
  • Manual QA for all new/changed functionality

Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Requesting a few small changes.

.github/workflows/dogfood-gitops.yml Outdated Show resolved Hide resolved
server/fleet/app.go Outdated Show resolved Hide resolved
pkg/spec/gitops_test.go Show resolved Hide resolved
getvictor
getvictor previously approved these changes May 10, 2024
Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucasmrod lucasmrod merged commit f8cee67 into main May 28, 2024
16 checks passed
@lucasmrod lucasmrod deleted the 17309-support-env-vars-profiles branch May 28, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants