add CLI and endpoints to set software via fleetctl apply #18876
Conversation
| } | ||
|
|
||
| g, workerCtx := errgroup.WithContext(ctx) | ||
| g.SetLimit(3) |
| case "msi": | ||
| name, version, shaSum, err = ExtractMSIMetadata(br) | ||
| default: | ||
| return "", "", "", nil, ErrUnsupportedType |
| @@ -559,6 +559,65 @@ func (c *Client) ApplyGroup( | |||
| tmScriptsPayloads[k] = scriptPayloads | |||
| } | |||
|
|
|||
| tmSoftware := extractTmSpecsSoftware(specs.Teams) | |||
There was a problem hiding this comment.
Just for my understanding, this adds the support for both fleetctl apply and fleetctl gitops? They both end up calling this ApplyGroup?
There was a problem hiding this comment.
thanks so much for this comment. I will upload the title of the issue to note that this is only for fleetctl apply. I might need to adjust gitops in a follow up because at first glance it's going to be a significant diff as well :(
There was a problem hiding this comment.
Argh :( I thought this was good for both. Let coordinate in slack if there are ways to split work for all the remaining bits.
There was a problem hiding this comment.
sounds good, thank you!!
Co-authored-by: Martin Angers <martin.n.angers@gmail.com>
roperzh
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat-software-installers #18876 +/- ##
===========================================================
Coverage ? 66.71%
===========================================================
Files ? 898
Lines ? 110937
Branches ? 0
===========================================================
Hits ? 74015
Misses ? 30912
Partials ? 6010
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@roperzh CI failure is unrelated ( |
|
@mna thanks! was driving me crazy |
for #18325
Checklist for submitter
If some of the following don't apply, delete the relevant line.
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)