Fleet UI: Updated styles to license expiration banner #18856
Merged
+95
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RachelElysia
commented
May 8, 2024
| @@ -6,5 +6,8 @@ | |||
| // of the main-content when there is a banner. (e.g. sandbox mode) | |||
| // Without it the main content pushes the banner off the page. | |||
| overflow: auto; | |||
| animation: fade-in 250ms ease-out; | |||
|
|
|||
| > :not(.main-content--animation-disabled) { | |||
There was a problem hiding this comment.
Open for other solutions to not make the banner flash on page change
tldr:
main-content has animation: fade-in 250ms ease-out; applied to it, but looks super weird to have that banner flash over and over on each page click since it's not moving (feels not React like at all!), so I removed the animation from the banners only by putting it in a div wrapper called .main-content--animation-disabled
|
👀 |
jacobshandling
approved these changes
May 21, 2024
| /> | ||
| )} | ||
| /> | ||
| <div className={`${baseClass}--animation-disabled`}> |
There was a problem hiding this comment.
Would React.memo izing the components prevent those undesired rerenders/animations?
| @@ -6,5 +6,8 @@ | |||
| // of the main-content when there is a banner. (e.g. sandbox mode) | |||
| // Without it the main content pushes the banner off the page. | |||
| overflow: auto; | |||
| animation: fade-in 250ms ease-out; | |||
|
|
|||
| > :not(.main-content--animation-disabled) { | |||
|
Merging before freeze. TODO: look into memoization to prevent rerenders |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Cerra #17860
Description
Other
<InfoBanner/>component and its stylingScreenshots
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.