Orbit software installer flow #18797
Conversation
dantecatalfamo
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
dantecatalfamo
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
dantecatalfamo
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
dantecatalfamo
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
dantecatalfamo
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
| // result because the back-end considers any non-empty | ||
| // string as a success. | ||
| // return false, fmt.Sprintf("osqueryd returned error (%d): %s", res.Status.Code, res.Status.Message), fmt.Errorf("non-zero query status: %d \"%s\"", res.Status.Code, res.Status.Message) | ||
| return false, "", fmt.Errorf("non-zero query status: %d \"%s\"", res.Status.Code, res.Status.Message) |
There was a problem hiding this comment.
I wan to call out this note, we probably need a status column in the database, which also implies modifying some of the queries.
With the cleanup done by Martin yesterday I don't think it'll be too hard, but I'm not sure if we have time to do it in this release.
There was a problem hiding this comment.
Yeah that wouldn't be too hard (still two places because there's the query-based computed status and one based on the fields of the Go struct), although for now maybe we can get away with returning empty string as you did here and just log the error client-side?
There was a problem hiding this comment.
sounds good, this error will bubble up to a log 👍
I'll note this somewhere (an issue?)
There was a problem hiding this comment.
Given that we'll build on top of this for self-service, I wonder if we could add some "improvements/refinements" ticket to it and add this there?
| } | ||
|
|
||
| return payload, nil | ||
| } |
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.