Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to lucene 7.5 #181

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Upgrade to lucene 7.5 #181

wants to merge 3 commits into from

Conversation

romseygeek
Copy link
Collaborator

This PR is a bare-bones upgrade, with no attempt at removing deprecations or reimplementing stuff. All tests pass, but it would be good to get some idea of any performance implications of these changes, particularly around the Multipass presearcher.

Fixes #146

@romseygeek
Copy link
Collaborator Author

cc @dcollins53 @mjustice3

@zcox
Copy link

zcox commented Dec 20, 2018

Hi - we have a project that is currently using Lucene 7.5.0 and just started looking at also using Luwak. Just out of curiosity, is it likely that this PR upgrading to 7.5 would move forward in the near future? Is anything major blocking the upgrade?

@romseygeek
Copy link
Collaborator Author

Hi @zcox, thanks for pinging! The only blocker here really is a check on the performance implications of the change, but I definitely plan on doing a release of luwak that will include this PR early in the new year. Can you build off the branch for now?

@zcox
Copy link

zcox commented Dec 21, 2018

@romseygeek - sounds great, we can definitely build off of this branch for now.

@magro
Copy link

magro commented Jan 24, 2019

@romseygeek Any update here? We're currently using a custom build off this branch but of course would prefer to use a published version.

@magro
Copy link

magro commented Mar 12, 2019

@romseygeek Can we help with anything that blocks merging this or that's related to publishing a new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants