Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Luwak for 6.6.1 and/or 7.x #146

Open
dcollins53 opened this issue Sep 26, 2017 · 2 comments
Open

Update Luwak for 6.6.1 and/or 7.x #146

dcollins53 opened this issue Sep 26, 2017 · 2 comments

Comments

@dcollins53
Copy link
Contributor

Any objections to moving Luwak to use a later Lucene 7.x release?

Tried 6.6.1 which Luwak seems to work fine with out of the box (not sure a release with just that is worth it?)

Also tried 7.0 which I broke down into a number of issues:

  • Legacy Numerics (RanqeQuery, TokenStream, etc)
  • TermsQuery has been replaced by TermInSetQuery
  • changes to createWeight API (addition of boost), no RandomAccessWeight, other Weight API changes
  • changes to LeafReader API (no fields)
  • changes to DocValue API (no direct getter)

Any thoughts on trying to work on those? I can have a stab where possible...

@romseygeek
Copy link
Collaborator

I'm not going to have time to do this immediately, but it's definitely on my list.

There will be a number of new queries to deal with too, and I think we can look at using some of the point range queries to allow the Presearcher to filter out point queries.

@dcollins53
Copy link
Contributor Author

dcollins53 commented Apr 18, 2018

#166, #167, #168, #169 are some PRs to remove use of classes which are not in Lucene 7, these are intended to be patched onto master (to prove all the functionality still works against Lucene 6) before the actual port to Lucene 7 (which should then just be API tweaks like LeafReader, DocValue, createWeight tweaks)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants