Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Segment and generalize Path #318

Draft
wants to merge 59 commits into
base: master
Choose a base branch
from
Draft

Add Segment and generalize Path #318

wants to merge 59 commits into from

Conversation

saraedum
Copy link
Member

@saraedum saraedum commented Sep 14, 2022 •
edited

part of #309

TODO
  • Segment is tested.
  • Ray is tested.
  • Methods involving Path are tested with paths containing segments:
    • Path itself
    • SegmentIterator
    • All deformations that can map a path.
  • SaddleConnection::start and SaddleConnection::end are tested
  • SaddleConnection::segment is tested
  • We can interact with segments from Python.
  • Write news.

@saraedum saraedum mentioned this pull request Sep 14, 2022
Open
@saraedum
Add test suite for Segment
134a5fa
@saraedum
Adapt to changes in Path
98eb663 
note that the Segment alias was private so this is not a breaking
change.
@saraedum
Drop unused aliases
327ff3a
@saraedum
Fix compilation error
9f3be69
@saraedum
Fix compiler warning
5eabf40
@saraedum
Add implementation stubs for Segment
2bf0798
@saraedum
Add Vector::parallel()
5fe2f32
@saraedum
Implement construction of Segment from full data
4a43f78
@saraedum
Implement hashing of Segments
c8fbeea
@saraedum
Fix missing import
64d8276
@saraedum
Add SegmentIterator stubs
3d7c6ed
@saraedum
Add Ray stubs
2995eea
@saraedum
Added preliminary news
af2044f
@saraedum
Implement Segment::saddleConnection()
5350840
@saraedum
Implement Segment::start(), end(), source(), target()
ce2a061
@saraedum
Implement Segment::surface(), vector()
46d6048
@saraedum
Implement printing of segments
0d36783
@saraedum
Implement equality of segments
14bbb4e
@saraedum
Make segments print in the same way that saddle connections print
0cbb3d4
@saraedum
Implement Path(Segment) constructor
3531dfa
@saraedum
Add Chain::vector() helper
147b0b8
@saraedum
Fix hashing of saddle connections
51fd649
@saraedum
Implement Segment::operator-
bd54f17
@saraedum
Implement Segment::ray()
524c223
@saraedum
Implement Ray constructors
ce71d12
@saraedum
Mostly implement Ray
41bbb67
@saraedum
Add TODO for segments
80833dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@saraedum