Merge pull request #335 from saraedum/idrepr

Improving printing of the identical deformation
flatsurf · Jan 10, 2024 · 53fd323 · 53fd323
2 parents a6e8c3d + c51dcff
commit 53fd323
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/doc/news/idrepr.rst b/doc/news/idrepr.rst
@@ -0,0 +1,3 @@
+**Fixed:**
+
+* Fixed printing of the trivial deformation to actually print as a deformation and not as the underlying surface.
diff --git a/libflatsurf/src/trivial_deformation_relation.cc b/libflatsurf/src/trivial_deformation_relation.cc
@@ -58,7 +58,7 @@ bool TrivialDeformationRelation<Surface>::trivial() const {
 
 template <typename Surface>
 std::ostream& TrivialDeformationRelation<Surface>::operator>>(std::ostream& os) const {
-  return os << this->domain;
+  return os << "Identity on " << this->domain;
 }
 
 }  // namespace flatsurf

diff --git a/pyflatsurf/test/deformation.py b/pyflatsurf/test/deformation.py
@@ -148,10 +148,14 @@ def test_deformation(surface):
     domain = surface.clone()
     track = cppyy.gbl.flatsurf.Tracked(surface.combinatorial(), cppyy.gbl.flatsurf.Deformation[type(surface)](domain))
 
+    assert repr(track).startswith("Identity ")
+
     for edge in surface.edges():
         if surface.convex(edge.positive(), True):
             surface.flip(edge.positive())
 
+    assert not repr(track).startswith("Identity ")
+
     assert track.domain() == domain
     assert track.codomain() == surface