notification: Use notification desktop-id to select backend and notify #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the gtk name owner value is set it should not be leaked, so use an auto-pointer for that.
Notifications can provide a specific desktop-id, in such case we should just use the fdo notifications (to ensure that such info is consumed by the shell) if the provided ID is not a FDO application ID and pass such value to it, while when it's a valid application ID we can just use the gtk backend to have the full experience. When desktop-id is not provided by the portal, it means it is matching the application-id, so we consider them the same.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Depends on flatpak/xdg-desktop-portal#904, converted to draft to avoid this getting merged before its required API is stable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the continuation of flatpak/xdg-desktop-portal#904
Notifications can provide a specific desktop-id, in such case we should
just use the fdo notifications (to ensure that such info is consumed by
the shell) if the provided ID is not a FDO application ID and pass such
value to it, while when it's a valid application ID we can just use the
gtk backend to have the full experience.
When desktop-id is not provided by the portal, it means it is matching
the application-id, so we consider them the same.