notification v2 specs: Allow passing GFileIcon, sound and add additional properties #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
jsparber
force-pushed
the
implement_v2_notification_spec
branch
2 times, most recently
from
bbe8883
to
57d6202
Compare
jsparber
changed the title
swick
reviewed
Apr 22, 2024
jsparber
force-pushed
the
implement_v2_notification_spec
branch
3 times, most recently
from
050fe36
to
03dd58c
Compare
swick
reviewed
Apr 23, 2024
jsparber
force-pushed
the
implement_v2_notification_spec
branch
2 times, most recently
from
595a948
to
ff872a1
Compare
|
Might want to put the autofd stuff into a new commit but otherwise this LGTM. |
Notification portal v2 allows passing a file-descriptors, so implement support for GFileIcon and convert it to a file-descriptor icon.
Notification portal v2 has a sound property allow users to set a sound file and get file-descriptor to the file that can be passed to the portal.
The notification specs v2 have some optional properties. This adds a method for querying those.
jsparber
force-pushed
the
implement_v2_notification_spec
branch
from
ff872a1
to
7c39eb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the new portal frontend in libportal flatpak/xdg-desktop-portal#1298