ci: Add dedicated job for documentation pages #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Fedora jobs build and deploy documentation twice, and that may be a problem. Use a dedicated workflow with proper a deploy job. This uses the Github Pages deploy action.
|
The |
TingPing
reviewed
Jan 13, 2024
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Configure libportal | ||
| run: meson setup --prefix=/usr builddir -Dbackend-gtk3=enabled -Dbackend-gtk4=enabled -Dbackend-qt5=enabled -Dbackend-qt6=enabled |
There was a problem hiding this comment.
I think you can disable all backends as they wouldn't affect the docs.
TingPing
reviewed
Jan 13, 2024
| run: meson setup --prefix=/usr builddir -Dbackend-gtk3=enabled -Dbackend-gtk4=enabled -Dbackend-qt5=enabled -Dbackend-qt6=enabled | ||
|
|
||
| - name: Build libportal | ||
| run: ninja -C builddir |
There was a problem hiding this comment.
Suggested change
| run: ninja -C builddir | |
| run: ninja -C builddir doc/libportal-1 |
Only build what is needed.
TingPing
reviewed
Jan 13, 2024
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Configure libportal | ||
| run: meson setup --prefix=/usr builddir -Dbackend-gtk3=enabled -Dbackend-gtk4=enabled -Dbackend-qt5=enabled -Dbackend-qt6=enabled |
There was a problem hiding this comment.
Suggested change
| run: meson setup --prefix=/usr builddir -Dbackend-gtk3=enabled -Dbackend-gtk4=enabled -Dbackend-qt5=enabled -Dbackend-qt6=enabled | |
| run: meson setup --prefix=/usr builddir -Dtests=false -Dvapi=false |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Fedora jobs build and deploy documentation twice, and that may be a problem.
Use a dedicated workflow with proper a deploy job. This uses the Github Pages deploy action.