New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move checks to dedicated script #98

Open

BalzaniEdoardo opened this issue Feb 9, 2024 · 1 comment

Collaborator

BalzaniEdoardo commented Feb 9, 2024

We should make general checks on the inputs for inputs that live in a dedicated script. This would disentangle the checks from the model.

The check should be like: check_at_least_2d, check_at_least_3d, or similar...

this type of generic check could be called by all sort of models in the future, not only GLMs.

Member

billbrod commented Feb 9, 2024

Agreed, maybe a validate.py or checks.py. Several of the functions from utils.py can also be moved there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment