Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification and transitioning in the documentation for convolution #131

Open
samdeoxys1 opened this issue Apr 13, 2024 · 0 comments
Open

Comments

@samdeoxys1
Copy link

When I was reading the doc for the basis convolution, I was tripped a little bit wondering what’s the right way to create features with basis. In the Causal, Anti-Causal and Acausal section you used create_convolutional_predictor and in the next section you switched to convolve using Basis.create_features. Perhaps some transition sentences saying sth along the line of “convolutional features can be created in these two ways; Basis.create_features is a convenient wrapper that allows easy combination of evaluation and convolution using basis) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant