Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-validation of NWB electrodes location for SI sorters Apps #33

Open
luiztauffer opened this issue Oct 29, 2023 · 1 comment
Open

Comments

@luiztauffer
Copy link
Collaborator

@magland
Should we include electrodes location data as a pre-validation step for SI-based sorters?
I just encountered an error during job execution due to a NWB file not having valid electrodes location information, this looks like a cheap validation to make and it would be very helpful.

We could have something similar to what already exists for electrical_series_path, but with electrode_table columns as options for location.

@alejoe91 it looks like in SI nwbextractor this info is hardcoded to be fetched from rel_x , rel_y and rel_z columns. Can we make this flexible?

@magland
Copy link
Collaborator

magland commented Oct 30, 2023

@luiztauffer that's a good idea

In pc-spike-sorting I use x, y, z and then fall back to rel_x, rel_y, rel_z. I agree this should be configurable somehow.

https://github.com/scratchrealm/pc-spike-sorting/blob/1c5250faf5219f056b266436c94fc14fc794a990/kilosort3/NwbRecording.py#L33-L51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants