add basic auth for web app #207
Open
+54
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love it lets merge! |
|
I like this feature! |
|
I'd love to see this merged. My solution using ngnix to enforce auth on the local network (except for localhost) is here, but having auth in app would be way better. #212 (comment) |
|
Hi, we are going to apply the basic authorization solution as soon as we verify that it works in the master/slave mode. |
|
@sprait Any update on this? Thanks. |
|
sorry, currently I don't have time to check it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I actively use this admin panel, but I'm very worried that any vpn user can access the admin panel from inside the network.
I suggest adding authentication in the application itself, since the proxy does not help if the user is inside the network.