New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement on compatibility to the iminuit >= 2.0 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e ones in the given `AbstractFit`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main changes
Cause the iminuit no longer supports passing arguments like
error_
limit_
, most of the changes are focused on converting the old way of calling iminuit to the compatible way.preprocess
function to parse the improper argumentscopy_state!
function to copy the initial statesdoctest
now must be disabled, cause this process somehow doesn't evaluate theLazyHelp
struct thus resulting in error, and the@autodocs
no longer works with theLazyHelp
eithersome problems
problem about parallel function
I decided to implement a parallel function based on the script I previously wrote, but due to the intrinsic properties of python and julia this is barely possible, here are the reasons:
so basically there is no way to encapsulate the script into a function
problem about the cost function class
The iminuit provides a class called cost function with lots of built-in functions and a better integration with the minuit class, but unfortunately, the cost functions inside it seems to use the broadcast which directly calls the function over a vector. Here the function is the probability density function used to calculate chisq, so it needs to be called inside python and it needs a dot to broadcast, that's where incompatibility comes from.