Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADX-1062 Default to "member" role for new requests #34

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

jonathansberry
Copy link
Member

@jonathansberry jonathansberry commented Oct 25, 2023

Description

Small change to ensure that the default value when selecting a role to join an organisation is member.

Also casts the return of the helper get_member_request_list from a FilterObject to a list because an empty FilterObject does not evaluate to False which is why the membership requests table shows in the front end even if there are no membership requests. .

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.

@jonathansberry jonathansberry changed the base branch from master to development October 25, 2023 08:32
@jonathansberry jonathansberry merged commit d9449b0 into development Oct 25, 2023
3 of 4 checks passed
@jonathansberry jonathansberry deleted the ADX-1062-default-role branch October 25, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants