Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADX 905 - Add the job title and affiliation to the membership requests #32

Conversation

A-Souhei
Copy link

@A-Souhei A-Souhei commented Apr 14, 2023

Description

Added job_list and affiliation in sent mail (for approval by admin) upon requesting new membership in an organisation

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.

Copy link
Member

@tomeksabala tomeksabala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good fix but we can't merge it into ytp-request (as job_title and affiliation are properties introduced in ckanext-unaids). This change should go alongside extending the UI tables for membership request inside ckanext-unaids.
I don't see any easy way to do this though. The change requires editing internals of ytp-request controllers and changing methods signatures. I suggest we drop this change and keep the job title and affiliation out of the emails being sent for the reuqest.

@A-Souhei
Copy link
Author

I close this PR then

@A-Souhei A-Souhei closed this Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants