Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPC-140 Allow collaborators to delete themselves #52

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

jonathansberry
Copy link
Member

@jonathansberry jonathansberry commented Oct 12, 2023

Description

Avenir would like collaborators to be able to delete themselves. This Pr adds a chained auth function that checks if someone is trying to delete themselves as a collaborator on a dataset. If they are, the auth check passes.

A small push back on this - the only way of undoing the action is to have the dataset re-shared with the individual. I suspect that an ideal engineering solution to this problem would actually maintain a seperate list of rejected shares (or alternatively think of them as "hidden shares"). So that the user can undo the decision without bothering the dataset creator if they so choose. That way you preserve the integrity of the list of collaborators being "the list of people the dataset owner is happy to share the data with".

But I appreciate this may be more work and complexity than it is worth.

Testing

A test is included for this new feature.

Documentation

Small updates have been made to the API documentation here.

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.

Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

With regards to your comment on re-sharing - for the AH use-case I think this is actually exactly what they want so no need to worry about "un-unsharing".

@jonathansberry jonathansberry merged commit f86ce2e into master Oct 12, 2023
2 checks passed
@jonathansberry jonathansberry deleted the SPC-140-collaborators branch October 12, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants