Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADX-985 Fixing pivot table pulls for cases where no dhis2 indicators selected #109

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

tomeksabala
Copy link
Member

Description

After introducing support for DHIS2 indicators it may happen that only dhis2 elements or only dhis2 indicators are selected for the pulls. This situation was not supported by the harvester and was causing issues downstream of the ETL (500 errors from DHIS2 complaining about incorrect API requests).

This fix prevents asking DHIS2 for indicators/data elements if no entries of this type exists for this pivot table configuration.

(This is a high-priority request for the client so I'm going ahead with deploying the change yet I still asking someone for post-merge review, please)

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • [ x] The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • [ x] I have developed these changes in discussion with the appropriate project manager.
  • [ x] My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • [ x] I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • [x ] I have performed a self-review of my own code.
  • [x ] I have assigned at least one reviewer.

@tomeksabala tomeksabala merged commit 2de5037 into development Mar 30, 2023
3 checks passed
@tomeksabala tomeksabala deleted the adx-985-fix-support-no-indicators branch March 30, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant