Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adx 1061 pipenv geoview #165

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Conversation

tomeksabala
Copy link
Member

Description

Please include a summary of the change(s).
You should also include screenshots or videos of UI changes.

You should include a link to the JIRA ticket and also a sentence summary of the motivation.

Don't forget to reference all other pull requests which are associated to this one below, especially if merging need to be coordinated.
E.g.

relates fjelltopp/repository_name#issue_number

Dependency Changes (delete if not applicable)

List any dependencies that have been removed/added/changed in this pull request and explain why.
Has the pipfile.lock or yarn.lock been updated?
If dependency management for this project is centralised, e.g. adx_deploy for ADR, please link to the coordinated PR in the project repo.

Testing (delete if not applicable)

Please describe the rationale behind any new tests that have been added for this change, e.g.

  • I have included automated unit tests for all features except V, because W
  • I have included automated integration tests for X that do Y
  • I have not included automated UI tests because Z
  • I have manually carried out the following tests that I have been unable to automate: A, B, C

Documentation (delete if not applicable)

Please describe any new technical documentation that has been added to Confluence for this change.

Environment Changes (delete if not applicable)

Have any environment variable changes been committed as part of this pull request?
Is there a matching PR in fjelltopp/fjelltop-infrastructure for these changes?
Have any README or Confluence install instructions been updated to reflect this change?

Internationalisation and Localisation (delete if not applicable)

Do any UI changes require internationalisation (i18n) or localisation (l10n) changes.
If new translations are required, have you created new Jira tickets for each language and informed the appropriate project manager?

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant