Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADX 905 - Add the job title and affiliation to the membership requests #143

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

ADX 905 - Add the job title and affiliation to the membership requests #143

wants to merge 1 commit into from

Conversation

A-Souhei
Copy link
Contributor

@A-Souhei A-Souhei commented Apr 24, 2023 •
edited

Description

Updates ckanext-unaides submodules for staging.

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.

@A-Souhei A-Souhei marked this pull request as ready for review April 24, 2023 14:26
tomeksabala
tomeksabala requested changes Apr 25, 2023
View reviewed changes
Copy link
Member

@tomeksabala tomeksabala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait with this PR and add here the fjelltopp/ckanext-unaids#277 is merged

@A-Souhei
Copy link
Contributor Author

A-Souhei commented Apr 25, 2023 •
edited

Can we merge this?

@tomeksabala
Copy link
Member

tomeksabala commented Apr 26, 2023 •
edited

@A-Souhei After fjelltopp/ckanext-unaids#277 is merged now can you please update the ckanext-unaids submodule to the latest version including this change v1.0.3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomeksabala tomeksabala tomeksabala requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@A-Souhei @tomeksabala