Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonce simplification #19

Merged
merged 5 commits into from Mar 27, 2024
Merged

Nonce simplification #19

merged 5 commits into from Mar 27, 2024

Conversation

expede
Copy link
Member

@expede expede commented Mar 27, 2024

  • Remove Nonce12 and generate_12
  • Nonce16 generation longer takes a seed

@expede expede marked this pull request as ready for review March 27, 2024 17:29
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 12.87%. Comparing base (7f680d3) to head (3e8826b).

❗ Current head 3e8826b differs from pull request most recent head 4d8ca6d. Consider uploading reports for the commit 4d8ca6d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           v1.0-rc.1      #19      +/-   ##
=============================================
- Coverage      13.00%   12.87%   -0.13%     
=============================================
  Files             68       68              
  Lines           5652     5615      -37     
  Branches        2709     2698      -11     
=============================================
- Hits             735      723      -12     
+ Misses          4313     4304       -9     
+ Partials         604      588      -16     
Files Coverage Δ
src/delegation/payload.rs 47.48% <ø> (+3.59%) ⬆️
src/invocation/payload.rs 33.13% <ø> (ø)
src/crypto/nonce.rs 57.77% <83.33%> (+5.33%) ⬆️
src/invocation/agent.rs 36.36% <0.00%> (ø)

... and 4 files with indirect coverage changes

src/crypto/nonce.rs Outdated Show resolved Hide resolved
src/crypto/nonce.rs Outdated Show resolved Hide resolved
Copy link
Member

@matheus23 matheus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! :) Thanks!

@expede expede merged commit 53c49d2 into v1.0-rc.1 Mar 27, 2024
3 of 7 checks passed
@expede expede deleted the nonce-simplification branch March 27, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants