Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unused imports #16

Merged
merged 5 commits into from Mar 28, 2024
Merged

Cleanup unused imports #16

merged 5 commits into from Mar 28, 2024

Conversation

expede
Copy link
Member

@expede expede commented Mar 26, 2024

Just what it says on the tin 🥫

Base automatically changed from remove-unrestricted-powerbox-chain to v1.0-rc.1 March 26, 2024 11:18
@expede expede marked this pull request as ready for review March 28, 2024 21:01
@expede
Copy link
Member Author

expede commented Mar 28, 2024

Given the long weekend coming up, I'm going to be evil and just self-review this. All of the tests continue to pass, and there "should" be no semantic changes in here.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 12.88%. Comparing base (d0fab39) to head (7186f09).
Report is 4 commits behind head on v1.0-rc.1.

❗ Current head 7186f09 differs from pull request most recent head 2955a7c. Consider uploading reports for the commit 2955a7c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           v1.0-rc.1      #16      +/-   ##
=============================================
- Coverage      13.14%   12.88%   -0.27%     
=============================================
  Files             68       68              
  Lines           5652     5620      -32     
  Branches        2709     2703       -6     
=============================================
- Hits             743      724      -19     
+ Misses          4313     4308       -5     
+ Partials         596      588       -8     
Files Coverage Δ
src/ability/crud/update.rs 0.00% <ø> (ø)
src/ability/msg.rs 46.87% <ø> (ø)
src/ability/ucan/revoke.rs 0.00% <ø> (ø)
src/crypto/nonce.rs 54.76% <ø> (+2.32%) ⬆️
src/delegation/payload.rs 46.89% <ø> (+0.85%) ⬆️
src/delegation/policy/predicate.rs 8.35% <ø> (ø)
src/delegation/policy/selector.rs 47.91% <ø> (ø)
src/delegation/policy/selector/select.rs 38.57% <ø> (ø)
src/did/key/signer.rs 13.79% <ø> (ø)
src/invocation/agent.rs 36.36% <ø> (ø)
... and 9 more

... and 3 files with indirect coverage changes

@expede expede merged commit a8d1b1d into v1.0-rc.1 Mar 28, 2024
5 of 9 checks passed
@expede expede deleted the unused-imports branch March 28, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant