Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unrestricted powerbox chain #15

Merged
merged 2 commits into from Mar 26, 2024

Conversation

expede
Copy link
Member

@expede expede commented Mar 26, 2024

While writing tests, I realised that it doesn't make sense to pass a subject: None to get_chain. This will just get you some random powerbox, so I removed the option 🤷‍♀️ It still searches the powerboxes, but you have to tell it where you want the chain to terminate.

@expede expede force-pushed the remove-unrestricted-powerbox-chain branch from 94e946f to 1b8382a Compare March 26, 2024 02:47
@expede expede force-pushed the remove-unrestricted-powerbox-chain branch from 1b8382a to 4913ad0 Compare March 26, 2024 02:48
@expede expede marked this pull request as ready for review March 26, 2024 02:48
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 12.86%. Comparing base (bc0a275) to head (4913ad0).

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           wrap_auto_cid_insert      #15      +/-   ##
========================================================
- Coverage                 12.90%   12.86%   -0.04%     
========================================================
  Files                        68       68              
  Lines                      5658     5660       +2     
  Branches                   2712     2714       +2     
========================================================
- Hits                        730      728       -2     
  Misses                     4319     4319              
- Partials                    609      613       +4     
Files Coverage Δ
src/delegation/store/traits.rs 85.71% <ø> (ø)
src/invocation/agent.rs 33.33% <0.00%> (ø)
src/delegation/store/memory.rs 26.15% <0.00%> (-0.84%) ⬇️

... and 1 file with indirect coverage changes

Base automatically changed from wrap_auto_cid_insert to v1.0-rc.1 March 26, 2024 11:15
@matheus23
Copy link
Member

Ah okay, so if I understand this correctly, powerlines should be created outside Store APIs in the future. E.g. in the short term via Delegation::try_sign and constructing a Payload, and in the long term with a builder, I assume.

@matheus23 matheus23 merged commit d854438 into v1.0-rc.1 Mar 26, 2024
6 of 11 checks passed
@matheus23 matheus23 deleted the remove-unrestricted-powerbox-chain branch March 26, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants