Wrap auto CID Insert error #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## test-deleg-store #13 +/- ##
====================================================
- Coverage 13.16% 12.90% -0.27%
====================================================
Files 68 68
Lines 5658 5658
Branches 2712 2712
====================================================
- Hits 745 730 -15
Misses 4319 4319
- Partials 594 609 +15
|
matheus23
reviewed
Mar 26, 2024
| fn insert( | ||
| &self, | ||
| delegation: Delegation<DID, V, C>, | ||
| ) -> Result<(), CannotCidOr<Self::DelegationStoreError>> { |
There was a problem hiding this comment.
Would prefer if we rename Self::DelegationStoreError to Error and CannotCidOr to DelegationStoreError ✌️
However, I'll keep the PR train going and add another PR on top that will do that rename :P
matheus23
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a
FIXMEon creating an automatic CIDs as part of a store insert