refactor: Make Agent take DID by value
#10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheus23
force-pushed
the
matheus23/v1.0-rc.1-no-agent-lifetime
branch
from
85c3701
to
254b7f4
Compare
expede
reviewed
Mar 20, 2024
| @@ -73,7 +72,7 @@ where | |||
| let nonce = Nonce::generate_12(&mut salt); | |||
|
|
|||
| if let Some(ref sub) = subject { | |||
| if sub == self.did { | |||
| if sub == &self.did { | |||
There was a problem hiding this comment.
Minor question about this, because I run into it a lot. There's two options:
if sub == &self.did
// vs
if *sub == self.didI assume that when you compare with &s, it has to deref these (which is extra indirection). The compiler can probably get rid of this, but do we know?
There was a problem hiding this comment.
Hm. Good question.
In the error message the compiler suggests &, but * totally works here, too.
expede
reviewed
Mar 20, 2024
| @@ -438,8 +435,7 @@ mod tests { | |||
| #[test_log::test] | |||
| fn test_invoker_is_sub_implicit_aud() -> TestResult { | |||
| let (_nbf, now, exp) = setup_valid_time(); | |||
| let (server, server_signer) = gen_did(); | |||
| let mut agent = setup_agent(&server, &server_signer); | |||
| let mut agent = setup_agent(); | |||
There was a problem hiding this comment.
Hm yeah this is a nice effect of this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this makes sense, because in practice, if
Agentis meant to be alive for a long time in a program, it's much easier to do that when it doesn't borrow data, but instead is self-contained. E.g. this way you can put it into an axum'sAppState, or hold it across an await point in a tokio task.The downside is that you're sometimes required to clone the
DIDandSignerthat you put into theAgent, but I'd argue that, the longer theAgentlives for, the less often you're required toclonesomething into it.