Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref-tables FR-AT reworked #260

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

Bluette-C-Riviere
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

{Summary of the changes}

Description

{Detail}

Fixes #{issue number}

@Bluette-C-Riviere Bluette-C-Riviere requested a review from a team May 8, 2023 06:18
@TSchmiedlechner
Copy link
Member

Hey @Bluette-C-Riviere, thanks for splitting this up! Some general observations:

  • The slugs in the file headers should be distinctive
  • File names must not contain spaces, those should be removed :)

I will go through the content in more detail later too

Bluette-C-Riviere and others added 20 commits May 25, 2023 07:16
@volllly volllly self-requested a review August 1, 2023 09:07
@volllly volllly requested a review from a team as a code owner October 23, 2023 11:20
@volllly
Copy link
Contributor

volllly commented Oct 23, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Bluette-C-Riviere Bluette-C-Riviere requested a review from a team as a code owner November 10, 2023 13:00
@volllly
Copy link
Contributor

volllly commented Nov 13, 2023

Hey, I've just noticed that these files don't have the .md file extension 😅

I think we'll also need to update the slugs in these files to be unique 🤔 @TSchmiedlechner can you confirm/deny that? (EDIT: ok I see you have already mentioned that #260 (comment) 😅)

Also we should remove the content from the reference-table.md so its not duplicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants