Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing England 1921 Census #4907

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kiwi3685
Copy link

1921 Census file added, and CensusOfEngland changed to include it.

I noticed this census was missing for latest webtrees. Hope it's useful.

1921 Census file added, and CensusOfEngland changed to include it,
@ddrury
Copy link
Contributor

ddrury commented Nov 28, 2023

There is an open issue for this - #4374. I started producing a PR but the column(s) for "Number and ages of all living children ..." defeated me (seee attached image). It seems to me that this should be a number of columns not one as your PR proposes and I'm interested in how you'd visualise completing this column.
166883710-b1cf9077-6037-41b1-8685-e4cf49a49733

@kiwi3685
Copy link
Author

kiwi3685 commented Nov 28, 2023

Adding 17 columns to make it exactly as per the original document is ridiculously impractical.

The single column in my pull request is for free-form text that allows users to add the same information in a simple way that suits their own preferences. The aim should be to capture the content and intent of the original document, not slavishly follow every part of the form. Some typical entries for that column from my own data include:

'Total 3 - 1 3y; 2 4y"
'2<1y'

@martins250
Copy link

Just hoping this can be included in the next webtrees version.

@martins250
Copy link

Update: Meantime, I have added/amended the two files to my docker installation of webtrees. All works well and I am happy that I can add all the 1921 Census information sensibly. Thank you kiwi3685.

@fisharebest
Copy link
Owner

Just hoping this can be included in the next webtrees version.

Not until we can decide how to implement these columns.

In other censuses, we have tried to copy the exact structure of the original document.

But such a large number of columns may be impractical.

I guess I need to implement both and see how they work in practice.

@kiwi3685
Copy link
Author

Is it possible for a custom module to over-ride an existing census template, or even multiple ones?

@ddrury
Copy link
Contributor

ddrury commented Mar 16, 2024

But such a large number of columns may be impractical.

The United states 1940 census has 31 columns which is more than the England 1921 census is likely to have even including the child count of age columns and that doesn't seem to cause problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants