Resize map to fit viewport on enter/exit of fullscreen #4814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4814 +/- ##
=========================================
Coverage 30.95% 30.95%
Complexity 11372 11372
=========================================
Files 1167 1167
Lines 47861 47861
=========================================
Hits 14813 14813
Misses 33048 33048 |
ddrury
force-pushed
the
resize_map_on_fullscreen
branch
from
ff1e598
to
6f737c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On fullscreen transition reset the map to initial conditions.
Note: I would like to carry forward any open popup on fullscreen transition but leaflet triggers the popupclose function at strange times, which currently I can't figure out
NOTE2: The changes to the map & tab phtml view files are hangovers from when the resize code was added to each view file rather than putting it into webtrees.js