Improve detection of map provider with missing Api key #4760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4760 +/- ##
=========================================
Coverage 30.94% 30.94%
+ Complexity 11357 11354 -3
=========================================
Files 1173 1173
Lines 47873 47865 -8
=========================================
Hits 14812 14812
+ Misses 33061 33053 -8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ddrury
changed the title
ddrury
force-pushed
the
Fix_map_providers
branch
3 times, most recently
from
6179f5b
to
90c2acb
Compare
ddrury
force-pushed
the
Fix_map_providers
branch
4 times, most recently
from
e5e11d0
to
9a0d645
Compare
ddrury
force-pushed
the
Fix_map_providers
branch
from
9a0d645
to
edba22d
Compare
ddrury
force-pushed
the
Fix_map_providers
branch
from
d9a8eda
to
b3ff7c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixs #4758 (now closed)
Applies to map providers that are enabled and require an api key but the key has been omitted.
For users without Admin permissions, previously for the offending provider an exception was raised which blocked access to all the maps. Now the offending provider is silently omitted from the list of available providers and an entry in the error log is made.
For Admin users an exception is raised with a link to the offending providers configuration page. (same as previously)