Fix #4700 - "Show all" does not display all individuals in list #4743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4743 +/- ##
=========================================
Coverage 30.89% 30.90%
- Complexity 11357 11358 +1
=========================================
Files 1188 1188
Lines 47891 47896 +5
=========================================
+ Hits 14796 14800 +4
- Misses 33095 33096 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jon48
force-pushed
the
hotfix/bug-4700
branch
from
7c07edd
to
94edd21
Compare
|
there has recently (#4904) been a change to this module, so that your patch is no longer valid. Please try actual code and perhaps create a new pull request and close this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of my comments about it are already in the bug section.
In the PR, I am giving a slightly different version than in my last comment, but hopefully, it has the same behavior.
It is the first time I have dug into the
n_surn/n_surnamelogic, and I hope I have not missing something fundamentals. Whilst testing, I noted some oddities around the "no surname" case, and case sensitivity, but I feel they go beyond that PR, and I will probably raise further issues to discuss those.