Finer control of abbreviate place names #3835
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3835 +/- ##
============================================
- Coverage 31.43% 31.42% -0.01%
- Complexity 11257 11258 +1
============================================
Files 1130 1130
Lines 39722 39725 +3
============================================
Hits 12485 12485
- Misses 27237 27240 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tronsmit
force-pushed
the
pedigree-places
branch
from
9a85fa0
to
a0e6cac
Compare
Finer control of abbreviate place names Motivation: Including highest level place name when abbrevaiting from back is not always desirable. This change will allow you to request the highest level to keep while always trying to show SHOW_PEDIGREE_PLACES number of levels Implementation: - add function backParts to Places - keep lastParts as it is used by census handlers - expand scope of SHOW_PEDIGREE_PLACES_SUFFIX so that 1=keep top level, 2=only keep to 2nd highest level, etc. Note: help text probably needs work
tronsmit
force-pushed
the
pedigree-places
branch
from
a0e6cac
to
5614bae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Including highest level place name when abbreviating from back is not always desirable. This requests which highest levels to omit while always trying to show SHOW_PEDIGREE_PLACES number of levels
Implementation:
Note: options text in tree preferences probably needs work