refactor(headless-client): split up the entry points for headless client and IPC service #4942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor/remove-linux-client
…ne into refactor/remove-auto-ipc
…ent and IPC service
ReactorScram
added
area/linux_client
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Terraform Cloud Plan Output |
…efactor/split-binaries
Signed-off-by: Reactor Scram <ReactorScram@users.noreply.github.com>
ReactorScram
changed the base branch from
refactor/remove-auto-ipc
to
fix/windows-dns-4899
…e into refactor/split-binaries
ReactorScram
commented
May 10, 2024
| @@ -131,8 +131,9 @@ jobs: | |||
| timeout 600 docker compose -f rust/snownet-tests/docker-compose.${{ matrix.name }}.yml up --exit-code-from dialer --abort-on-container-exit | |||
|
|
|||
| compatibility-tests: | |||
| # Tests the older, published Client and Gateway against the new infrastructure | |||
There was a problem hiding this comment.
I could not remember which way it went
ReactorScram
commented
May 10, 2024
| # Don't run compatibility tests when called from hotfix.yml or publish.yml on `main` because | ||
| # it'll be red if there was a breaking change we're tring to publish, | ||
| # it'll be red if there was a breaking change we're trying to publish, |
There was a problem hiding this comment.
noticed this typo while working on this
ReactorScram
commented
May 10, 2024
| @@ -320,7 +320,6 @@ services: | |||
| - type=registry,ref=us-east1-docker.pkg.dev/firezone-staging/cache/client:main | |||
| args: | |||
| PACKAGE: firezone-headless-client | |||
| # Add "standalone" to the command here once PR $4604 merges | |||
There was a problem hiding this comment.
Changing CLI args is complicated, skipping it for now
Performance Test ResultsTCP
UDP
|
|
Closing in favor of #4953. The refactors are taking too long so I'll skip most of them for now and try to do IPC without the refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds atop #4930 and #4943
Tasks