Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(relay): fix otel endpoint type #4932

Closed
wants to merge 1 commit into from
Closed

fix(relay): fix otel endpoint type #4932

wants to merge 1 commit into from

Conversation

Intuinewin
Copy link
Contributor

Completely forgot this #3251

This is the PR you asked for :/

@vercel Vercel
Copy link

vercel bot commented May 9, 2024

@Intuinewin is attempting to deploy a commit to the Firezone Team on Vercel.

A member of the Team first needs to authorize it.

@jamilbk jamilbk requested a review from AndrewDryga May 9, 2024 13:44
@jamilbk
Copy link
Member

jamilbk commented May 9, 2024

Completely forgot this #3251

This is the PR you asked for :/

Thanks for the contribution!

@AndrewDryga AndrewDryga requested review from thomaseizinger and removed request for thomaseizinger and AndrewDryga May 20, 2024 16:00
@thomaseizinger
Copy link
Member

Can you add a test using https://docs.rs/clap/latest/clap/trait.Parser.html#method.try_parse_from that ensures we accept a DNS name? I am worried that if we don't have a test for this, we will forget about this requirement and change it back to a socket address or something else in a refactoring.

@Intuinewin
Copy link
Contributor Author

Rebased with a test !

thomaseizinger
thomaseizinger approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@thomaseizinger thomaseizinger left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Unfortunately our CI is not optimised for contributions from forks yet so I am going to take your commit and push it to a local branch and merge it from there. The attribution should stay in-tact through that!

@thomaseizinger thomaseizinger mentioned this pull request May 21, 2024
Merged
@thomaseizinger
Copy link
Member

Replaced by #5059.

@jamilbk
Copy link
Member

jamilbk commented May 21, 2024

Thanks!

Unfortunately our CI is not optimised for contributions from forks yet so I am going to take your commit and push it to a local branch and merge it from there. The attribution should stay in-tact through that!

Another option is changing the base of this PR to a contrib branch, open a Pr with that, then merging.

That'll prevent having to close unmerged PRs

@thomaseizinger
Copy link
Member

Ah that is a good idea! I'll do that next time!

github-merge-queue bot pushed a commit that referenced this pull request May 22, 2024
@thomaseizinger @Intuinewin
chore(relay): allow domains in --otel-grpc-endpoint (#5059)
99c600f 
Replaces #4932.

---------

Co-authored-by: Antoine Labarussias <antoinelabarussias@gmail.com>
@Intuinewin Intuinewin deleted the fix-otel-endpoint branch May 22, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Intuinewin @jamilbk @thomaseizinger