Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump quinn-udp from 88f48b0 to 1e54758 in /rust #4904

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 7, 2024

Bumps quinn-udp from 88f48b0 to 1e54758.

Commits
  • 1e54758 quinn: alphabetize default features
  • 359c0c7 Add ring to default features
  • 0e9a196 Rename UnknownStream to ClosedStream for clarity
  • 130d956 Don't treat UnknownStream as an error in SendStream::stopped
  • b42e21e Make SendStream::finish synchronous
  • f28cb3d Check compilation without default features in CI
  • 272dd5d quinn: add proper guards to Endpoint constructor helpers
  • 74c0358 quinn: UdpPoller::new() is only called if a runtime is enabled
  • faf7dbc quinn: require rustls for insecure_connection example
  • e764fe4 proto: remove incorrect feature guard
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [quinn-udp](https://github.com/quinn-rs/quinn) from `88f48b0` to `1e54758`.
- [Release notes](https://github.com/quinn-rs/quinn/releases)
- [Commits](quinn-rs/quinn@88f48b0...1e54758)

---
updated-dependencies:
- dependency-name: quinn-udp
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels May 7, 2024
Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 8:05pm

Copy link

github-actions bot commented May 7, 2024

Terraform Cloud Plan Output

Plan: 15 to add, 15 to change, 15 to destroy.

Terraform Cloud Plan

Copy link
Member

@jamilbk jamilbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like some API changes 😿

@thomaseizinger
Copy link
Member

thomaseizinger commented May 10, 2024

looks like some API changes 😿

Less allocations when sending data (click on "Files changed"): quinn-rs/quinn@88f48b0...1e54758#diff-a4c3723adabe724e50ad02cdb86f1a32242ee842f2991b7dad5152265bf955e3

This will require some refactoring because we currently rely on being able to construct an owned Transmit (sometimes). We might have to send a patch upstream to turn this into a Cow.

@thomaseizinger
Copy link
Member

It also appears that we can no longer pass a slice of messages to send and now need to queue each message separately. Looking at the old implementation, it also just used a loop for this so I am not sure if this interferes with GSO?

Copy link
Contributor Author

dependabot bot commented on behalf of github May 13, 2024

Superseded by #4972.

@dependabot dependabot bot closed this May 13, 2024
@dependabot dependabot bot deleted the dependabot/cargo/rust/quinn-udp-1e54758 branch May 13, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants