Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(connlib): remove STUN-only functionality #4165

Closed
wants to merge 4 commits into from

Conversation

thomaseizinger
Copy link
Member

@thomaseizinger thomaseizinger commented Mar 16, 2024

With this PR, we ignore all "stun" relays sent from the portal.

Follow-up from: #3353.

Copy link

vercel bot commented Mar 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview Mar 16, 2024 5:38am

Copy link

github-actions bot commented Mar 16, 2024

Terraform Cloud Plan Output

Plan: 8 to add, 7 to change, 8 to destroy.

Terraform Cloud Plan

@thomaseizinger
Copy link
Member Author

With this PR, we ignore or "stun" relays sent from the portal.

cc @AndrewDryga I am not sure if the portal still supports that but after this PR, we can remove it!

Copy link

github-actions bot commented Mar 16, 2024

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 230.8 MiB (+0%) 232.8 MiB (+0%) 80 (-40%)
direct-tcp-server2client 240.3 MiB (+2%) 242.1 MiB (+2%) 459 (+286%)
relayed-tcp-client2server 147.8 MiB (-1%) 148.5 MiB (-1%) 155 (+5%)
relayed-tcp-server2client 150.7 MiB (+2%) 151.2 MiB (+2%) 176 (+1%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 50.0 MiB (+0%) 0.04ms (-4%) 0.00% (NaN%)
direct-udp-server2client 50.0 MiB (+0%) 0.01ms (-29%) 0.00% (NaN%)
relayed-udp-client2server 50.0 MiB (+0%) 0.08ms (-65%) 0.00% (NaN%)
relayed-udp-server2client 50.0 MiB (-0%) 0.04ms (-19%) 0.00% (NaN%)

@thomaseizinger thomaseizinger marked this pull request as draft March 16, 2024 05:49
@thomaseizinger
Copy link
Member Author

I need to think about how we want to migrate the snownet tests.

@jamilbk
Copy link
Member

jamilbk commented Mar 16, 2024

We may want to hold on merging any risky refactors while we work to stabilize things for GA. I think there's quite a bit of cleanup in the portal to remove the user facing piece of the STUN-only feature, today it's just being hidden.

@jamilbk
Copy link
Member

jamilbk commented Mar 16, 2024

I'm surprised the integration tests pass if this is a breaking API change?

@thomaseizinger
Copy link
Member Author

I'm surprised the integration tests pass if this is a breaking API change?

I've left the messages there so we can still parse the STUN server but just ignore it.

@thomaseizinger
Copy link
Member Author

Outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants