Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies from package.json #6730

Merged
merged 8 commits into from
May 21, 2024

Conversation

parkerbxyz
Copy link
Contributor

@parkerbxyz parkerbxyz commented Apr 27, 2024

This pull request removes unused dependencies from the root package.json file and deletes unused package.json files. I used depcheck to find the unused dependencies. This will resolve many of the 146 open Dependabot alerts for vulnerable dependencies that are not in use.

@parkerbxyz parkerbxyz changed the title Remove unused dependencies from root package.json Remove unused dependencies from root package.json Apr 27, 2024
@parkerbxyz parkerbxyz marked this pull request as ready for review May 1, 2024 23:55
MelvinTo
MelvinTo previously approved these changes May 13, 2024
Copy link
Collaborator

@drahnieR drahnieR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quite a few dependencies are actually in use, i've marked those inline

package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@parkerbxyz
Copy link
Contributor Author

quite a few dependencies are actually in use, i've marked those inline

I saw that some of these are in use in subdirectories that have their own package.json. Are these in use by scripts that use package.json in the root directory?

@drahnieR
Copy link
Collaborator

drahnieR commented May 15, 2024

That's true, but we are not really using api/package.json in practice. package.json under root should be including every module across whole project.
I think you could remove api/package.json in this PR

@parkerbxyz parkerbxyz changed the title Remove unused dependencies from root package.json Remove unused dependencies from package.json May 15, 2024
@parkerbxyz parkerbxyz requested a review from drahnieR May 15, 2024 20:29
@parkerbxyz
Copy link
Contributor Author

That's true, but we are not really using api/package.json in practice. package.json under root should be including every module across whole project. I think you could remove api/package.json in this PR

Got it. I removed unused package.json files and restored dependencies that are still in use to the root package.json file.

@parkerbxyz parkerbxyz requested a review from MelvinTo May 20, 2024 18:03
@MelvinTo MelvinTo merged commit ca0fcb6 into firewalla:master May 21, 2024
1 check passed
@parkerbxyz parkerbxyz deleted the update-dependencies branch May 21, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants