Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Feature To Optionally Limit ID Reuse in Timing Model #914

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davidbiancolin
Copy link
Contributor

Resolves #643, by adding a UserYanker internally to the timing model. This can be optionally disabled in timing models where it safe to have transactions under the same ID in flight.

This crashes in elaboration, since the output FIRRTL is malformed.

  • TODO: do not emit when max flight is capped already to 1 in the target.

Related PRs / Issues

#643

UI / API Impact

New parameter added to FASEDTiming models.

Verilog / AGFI Compatibility

Needs AGFI regeneration.

Contributor Checklist

  • Did you set dev as the base branch?
  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • (If applicable) Did you regenerate and publicly share default AGFIs?
  • (If applicable) Did you mark the PR as "Please Backport"?
  • (On merge) Did you update release notes in the dev-to-master PR ?

Reviewer Checklist (only modified by reviewer)

  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@davidbiancolin davidbiancolin temporarily deployed to use-fpgas January 27, 2022 19:06 Inactive
@davidbiancolin
Copy link
Contributor Author

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Feb 22, 2022

rebase

✅ Branch has been successfully rebased

@davidbiancolin
Copy link
Contributor Author

@Mergifyio rebase

@davidbiancolin davidbiancolin changed the base branch from dev to main February 22, 2022 18:19
@mergify
Copy link
Contributor

mergify bot commented Feb 22, 2022

rebase

✅ Branch has been successfully rebased

@davidbiancolin
Copy link
Contributor Author

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Feb 22, 2022

rebase

☑️ Nothing to do

  • -closed [:pushpin: rebase requirement]
  • #commits-behind>0 [:pushpin: rebase requirement]

@davidbiancolin davidbiancolin temporarily deployed to use-fpgas February 22, 2022 19:23 Inactive
@sagark sagark added this to the 1.15.0 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LLC responses to backend with the same ID are not in correct order
2 participants