Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detach the firesim/chipyard build.sbts #1723

Merged
merged 5 commits into from Apr 29, 2024
Merged

Detach the firesim/chipyard build.sbts #1723

merged 5 commits into from Apr 29, 2024

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented Apr 25, 2024

Now firesim uses its own build.sbt to compile the goldengate/midas/firesim-main jar, while the target jar is compiled using chipyard's build.sbt. This lets us move towards detaching these projects.

The new chipyard-symlink symlink is necessary because the sim/build.sbt expects all the the chipyard-managed sources in firesim-as-library mode to be below it in the file tree.

Related PRs / Issues

UI / API Impact

Verilog / AGFI Compatibility

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@jerryz123 jerryz123 changed the title Detach firesim from chipyard's build.sbt Detach the firesim/chipyard build.sbts Apr 25, 2024
Copy link
Contributor

@joonho3020 joonho3020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerryz123 jerryz123 merged commit 2afc3d8 into main Apr 29, 2024
12 checks passed
@jerryz123 jerryz123 deleted the decirc branch April 29, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants