Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch HTIF exceptions and fix TracerV bridge for larger iaddr widths #1721

Merged
merged 3 commits into from Apr 30, 2024

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Apr 20, 2024

This PR does 2 things:

  • Throw exceptions from program loading. Originally, if the HTIF thread threw an exception in VCS it would give a gibberish exception message to STDOUT. This PR instead catches that exception, prints something reasonable out to the console, and then errors.
  • Fixes TracerV bridge for any iaddr width < 64. With the bump to SV48 in Chipyard, TracerV was broken since it expected the iaddr width to be 40 (and the valid bit to be in the 41th bit position). This fixes that assumption by just putting the valid bit at the end of integer (i.e. 64th bit).

Related PRs / Issues

UI / API Impact

Verilog / AGFI Compatibility

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@abejgonzalez abejgonzalez added the changelog:fixed Put PR title in 'Fixed' section of changelog label Apr 20, 2024
@abejgonzalez abejgonzalez self-assigned this Apr 20, 2024
Copy link
Contributor

@joonho3020 joonho3020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abejgonzalez abejgonzalez merged commit 9073271 into main Apr 30, 2024
12 checks passed
@abejgonzalez abejgonzalez deleted the misc-fixes branch April 30, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed Put PR title in 'Fixed' section of changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants