Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple build recipe sweep script #1705

Merged
merged 3 commits into from Apr 30, 2024
Merged

Simple build recipe sweep script #1705

merged 3 commits into from Apr 30, 2024

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Mar 15, 2024

Adds a simple script that can sweep a single build recipe for its maximum frequency. Under the hood, this completes a n-ary search over frequencies using N build machines (user-specified).

Related PRs / Issues

UI / API Impact

Verilog / AGFI Compatibility

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@abejgonzalez abejgonzalez added changelog:added Put PR title in 'Added' section of changelog and removed DONOTMERGE labels Apr 15, 2024
@abejgonzalez abejgonzalez changed the title [WIP] Build recipe sweep script Simple build recipe sweep script Apr 15, 2024
@abejgonzalez abejgonzalez marked this pull request as ready for review April 15, 2024 21:41
Copy link
Contributor

@joonho3020 joonho3020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to leave the debug prints?
Otherwise LGTM

@abejgonzalez
Copy link
Contributor Author

Cancelled CI since this doesn't affect it.

@abejgonzalez abejgonzalez merged commit 07e480d into main Apr 30, 2024
7 of 12 checks passed
@abejgonzalez abejgonzalez deleted the hwdb-sweep-helper branch April 30, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:added Put PR title in 'Added' section of changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants