Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BRAMQueue | Add working FireSimQueueHelper #1679

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

abejgonzalez
Copy link
Contributor

The BRAMQueue is no longer necessary since the normal Chisel queue has a syncReadMem functionality. Instead use that by default. Additionally updates the FireSimQueueHelper to be more robust and adds heuristics.

Related PRs / Issues

UI / API Impact

Verilog / AGFI Compatibility

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@abejgonzalez
Copy link
Contributor Author

@Mergifyio rebase main

@abejgonzalez abejgonzalez added the changelog:changed Put PR title in 'Changed' section of changelog label Jan 18, 2024
Copy link
Contributor

mergify bot commented Jan 18, 2024

rebase main

✅ Branch has been successfully rebased

Copy link

@junsunchoi junsunchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@abejgonzalez abejgonzalez merged commit 3dd8348 into main Jan 19, 2024
12 checks passed
@abejgonzalez abejgonzalez deleted the update-bram branch January 19, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:changed Put PR title in 'Changed' section of changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants