Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BRAMQueue to targetutils #1673

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Move BRAMQueue to targetutils #1673

merged 1 commit into from
Nov 21, 2023

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Nov 17, 2023

Downstream repos that use targetutils might want to instantiate queues that infer to BRAM (or other Xilinx memory primitives - i.e. URAMs). This PR exposes the BRAMQueue to targetutils so that users can add it. By default it defaults to inferring BRAM, but users can override this using the XDC hint utilities. Also adds a FireSimQueueHelper object that given a boolean chooses between a normal queue or BRAM queue (for ease of use).

Related PRs / Issues

UI / API Impact

Verilog / AGFI Compatibility

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@abejgonzalez abejgonzalez added DONOTMERGE changelog:changed Put PR title in 'Changed' section of changelog labels Nov 17, 2023
@abejgonzalez abejgonzalez self-assigned this Nov 17, 2023
@abejgonzalez
Copy link
Contributor Author

Waiting for #1672 so we can run CI on this PR.

Copy link

@junsunchoi junsunchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link

@junsunchoi junsunchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@abejgonzalez
Copy link
Contributor Author

@mergify rebase

Copy link
Contributor

mergify bot commented Nov 20, 2023

rebase

✅ Branch has been successfully rebased

@abejgonzalez abejgonzalez merged commit e053cf8 into main Nov 21, 2023
12 checks passed
@abejgonzalez abejgonzalez deleted the move-bram-targetutils branch November 21, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:changed Put PR title in 'Changed' section of changelog DONOTMERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants