Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAQ page for doc/On-Premises-FPGA-Getting-Started #1612

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

william-lyh
Copy link
Contributor

Related PRs / Issues

None

UI / API Impact

No impact

Verilog / AGFI Compatibility

No impact

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@william-lyh william-lyh added the changelog:added Put PR title in 'Added' section of changelog label Jul 21, 2023
@william-lyh william-lyh self-assigned this Jul 21, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to point to this file in the index.rst (otherwise it won't get rendered).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file should also not be named "Template" since it's not being templatized. Or IMO, this might be better to be added to each FPGA section as a template (i.e. each FPGA part of the docs has it's own FAQ).


To streamline the set-up process, we provide fix suggestions to the following errors that might appear during the process for reference.

**SSH Setup**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a subtitle not bold.


Please also note that ssh-agent might need to be set-up each time a new terminal is started.

**Build Bitstream**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

To streamline the set-up process, we provide fix suggestions to the following errors that might appear during the process for reference.

**SSH Setup**
``build bitstream`` process stuck at ::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't unique to just the buildbitstream... this happens on a lot of FireSim steps. I would generalize a bit more here.

Comment on lines +9 to +10
[localhost] local: pwd
[localhost] run: ...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the code-block directive (search in other parts of the docs)

[localhost] run: ...


The manager machine should be able to use ssh protocal to connect to build_farm and run_farm machines without providing password or passphrase duirng the connection process.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead, I would say that there is no passwordless access to the machine in question (i.e. localhost). And I would add a link to SSH setup docs that already exist.

Comment on lines +15 to +19
Verify this by using ``ssh`` command from the manager machine. If a password or passphrase prompt appears, ssh-agent can be used to store and automatically provide login credentials. ::

ssh-agent -s > AGENT_VARS
source AGENT_VARS
ssh-add ~/.ssh/firesim.pem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would try to dedup. this with the other parts of the documentation (for easier future maintenance).

source AGENT_VARS
ssh-add ~/.ssh/firesim.pem

Please also note that ssh-agent might need to be set-up each time a new terminal is started.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Anything that is referenced in the code (or must be typed in the CLI) should be put in backticks (`)


This error is probably due to shell login scripts writing to standard out.

Edit ``~/.bashrc`` and/or other login scripts to make sure standard out writing commands such as ``echo`` are either commented out or only executed when the shell is in interactive mode(directly receving commands typed by a user).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Edit ``~/.bashrc`` and/or other login scripts to make sure standard out writing commands such as ``echo`` are either commented out or only executed when the shell is in interactive mode(directly receving commands typed by a user).
Edit ``~/.bashrc`` and/or other login scripts to make sure that commands that write to stdout (such as ``echo``) are either commented out or only executed when the shell is in interactive mode (directly receiving commands typed by a user).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:added Put PR title in 'Added' section of changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants