New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TraceDoctor #1501
Open
bgottschall
wants to merge
15
commits into
firesim:main
Choose a base branch
from
EECS-NTNU:tracedoctor
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
TraceDoctor #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TraceDoctor TracerV example does now support FirePerf
…and compiler warnings
* moved away from shared_ptr because not necessary * fixed a threading bug * worker register now easier
+ fix in argument parsing (bug introduced by const references)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TraceDoctor support for FireSim.
Reference: ucb-bar/chipyard#1469
There is currently some code commented out in the TraceDoctorBridge.scala and an assert that the trace vector width cannot be chosen higher than 512 bits because of the DMA token size.
The commented-out code enables support for more than 512 bits with the cost of simulation speed. This code should be reviewed in line with the recent TracerV support for more than 7 instructions.