Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all FireSim workloads to Marshal configs #1340

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Dec 20, 2022

Instead of using the older method of generating a rootfs from the .json workload file, instead, standardize to using FireMarshal workload definitions for the workloads.

TODO/Things to note:

  • Test all workloads to ensure they still work (They were tested briefly with QEMU/Spike but failed since some require networked connections).
  • I removed the GAPBS scripts since the directory was not specified / the workload was broken (probably should fix)
  • When installing the workload, a folder is generated in deploy/workloads that isn't tracked in the .gitignore (probably need to rework the .gitignore a bit
  • Individually port each of the workloads in separate PRs for less PR reviewer burden. Separate out Chipyard bump
  • What to do with checksum-test? Probably go back in history and see if this was working?

Related PRs / Issues

UI / API Impact

Verilog / AGFI Compatibility

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@abejgonzalez abejgonzalez mentioned this pull request Dec 22, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant