Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manager: have manager copy back results on kill #1315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davidbiancolin
Copy link
Contributor

I find this incredible useful when debugging simulators that hang. Maybe others would too.

It's a bit of hack because doing it right depends (I think?) on looking up state from runworkload which is lost (e.g., what was the results-directory?). Until there is some datastructure that persists (and would enable stuff like firesim resume). Do the hacky thing of just copying all results back.

@sagark if i'm being stupid a missed something obvious, tell me how to do this better.

Related PRs / Issues

UI / API Impact

firesim kill will now unconditionally copy all results back.

Verilog / AGFI Compatibility

None

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@sagark
Copy link
Member

sagark commented Mar 10, 2023

This looks fine to me, but can we hide this behind a flag? e.g.:

firesim kill --force_results_copy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:changed Put PR title in 'Changed' section of changelog ci:fpga-deploy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants