manager: have manager copy back results on kill #1315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find this incredible useful when debugging simulators that hang. Maybe others would too.
It's a bit of hack because doing it right depends (I think?) on looking up state from
runworkload
which is lost (e.g., what was the results-directory?). Until there is some datastructure that persists (and would enable stuff likefiresim resume
). Do the hacky thing of just copying all results back.@sagark if i'm being stupid a missed something obvious, tell me how to do this better.
Related PRs / Issues
UI / API Impact
firesim kill
will now unconditionally copy all results back.Verilog / AGFI Compatibility
None
Contributor Checklist
changelog:<topic>
label?ci:fpga-deploy
label?Please Backport
label?Reviewer Checklist (only modified by reviewer)
Note: to run CI on PRs from forks, comment
@Mergifyio copy main
and manage the change from the new PR.changelog:<topic>
label?