Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manager: Fix Vitis Deployments that aren't running on localhost #1297

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

davidbiancolin
Copy link
Contributor

I ran into two issues:

  1. The xclbin was never actually copied to the remote (unless i'm missing something?)
  2. The way xbutil reset was invoked was broken, because the result of examine would be captured on the remote and thus inaccessible to the manager.

Related PRs / Issues

None

UI / API Impact

None

Verilog / AGFI Compatibility

None

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

This will work on Vitis-based deployments that aren't just locally hosted

(cherry picked from commit ede5b2f9d66c9b903fe673e8b5a9a0ca4493e745)
(cherry picked from commit eef344d5912c33c3323b127823b01fec67cfd629)
@davidbiancolin davidbiancolin added changelog:fixed Put PR title in 'Fixed' section of changelog ci:fpga-deploy labels Nov 11, 2022
@davidbiancolin davidbiancolin changed the title Manager: Fix Vitis Deployments taht aren't running on localhost Manager: Fix Vitis Deployments that aren't running on localhost Nov 11, 2022
@davidbiancolin
Copy link
Contributor Author

Follow up: this doesn't appear to work on mill because the encoding of the string (i suspect) is wonky in such a way that the json deserializer breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed Put PR title in 'Fixed' section of changelog DONOTMERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants